[ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839635#comment-15839635 ]
Martijn van Groningen commented on LUCENE-6959: ----------------------------------------------- bq. Do we really need the {{origChildQuery}} anymore? In case the query get rewritten and if it happened to get cached? > Remove ToParentBlockJoinCollector > --------------------------------- > > Key: LUCENE-6959 > URL: https://issues.apache.org/jira/browse/LUCENE-6959 > Project: Lucene - Core > Issue Type: Task > Reporter: Adrien Grand > Assignee: Adrien Grand > Priority: Minor > Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE-6959.patch > > > This collector uses the getWeight() and getChildren() methods from the passed > in Scorer, which are not always available (eg. disjunctions expose fake > scorers) hence the need for a dedicated IndexSearcher > (ToParentBlockJoinIndexSearcher). Given that this is the only collector in > this case, I would like to remove it. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org