[ 
https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839694#comment-15839694
 ] 

Martijn van Groningen edited comment on LUCENE-6959 at 1/26/17 1:51 PM:
------------------------------------------------------------------------

I was wrong, `origChildQuery` can be removed as rewritten queries are used as 
cache key in query cache.


was (Author: martijn.v.groningen):
I was wrong, it can `origChildQuery` can be removed as rewritten queries are 
used as cache key in query cache.

> Remove ToParentBlockJoinCollector
> ---------------------------------
>
>                 Key: LUCENE-6959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6959
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE_6959.patch, LUCENE_6959.patch, LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed 
> in Scorer, which are not always available (eg. disjunctions expose fake 
> scorers) hence the need for a dedicated IndexSearcher 
> (ToParentBlockJoinIndexSearcher). Given that this is the only collector in 
> this case, I would like to remove it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to