[
https://issues.apache.org/jira/browse/SOLR-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847548#comment-15847548
]
Erick Erickson commented on SOLR-10080:
---------------------------------------
Pushkar:
One technique people use for marking code that needs to be cleaned up is to add
a //nocommit comment to it. The precommit step will flag all //nocommit entries
and fail the build so it's a sure-fire way to make sure any lingering questions
are cleaned up.
Of course then when you're all ready to add it you have to run the 'ant
precommit' step, but even if you don't the next Jenkins build will so...
No big deal, just FYI...
> Fix some issues reported by findbugs
> -------------------------------------
>
> Key: SOLR-10080
> URL: https://issues.apache.org/jira/browse/SOLR-10080
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Pushkar Raste
> Priority: Minor
> Attachments: SOLR-10080.patch
>
>
> I ran a findbugs analysis on code and found a lot of issues. I found issues
> in both lucene and solr, however, I am not sure whether Solr developers
> should fix issues like this in the lucene code or not.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
