[ 
https://issues.apache.org/jira/browse/SOLR-9912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854706#comment-15854706
 ] 

David Smiley commented on SOLR-9912:
------------------------------------

Looking good.  I like the use of {{Predicate.and}}.

Might you make {{ExcludeBytesRefFilter}} an anonymous inner class instead a top 
level public class?  It's really small and it's yet another file / thing to 
name.

> SimpleFacets - support facet.excludeTerms parameter
> ---------------------------------------------------
>
>                 Key: SOLR-9912
>                 URL: https://issues.apache.org/jira/browse/SOLR-9912
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Jonny Marks
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-9912.patch, SOLR-9912.patch, SOLR-9912.patch
>
>
> This ticket is for supporting a new facet.excludeTerms parameter for removing 
> specific terms from the facet counts, without having to exclude the terms 
> from the index itself.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to