Hi Adrien,

what do you think about this issue?
https://issues.apache.org/jira/browse/LUCENE-7651

Uwe

-----
Uwe Schindler
Achterdiek 19, D-28357 Bremen
http://www.thetaphi.de
eMail: [email protected]

> -----Original Message-----
> From: Uwe Schindler (JIRA) [mailto:[email protected]]
> Sent: Tuesday, February 7, 2017 11:44 AM
> To: [email protected]
> Subject: [jira] [Commented] (LUCENE-7651) Javadocs build fails with Java 8
> update 121
> 
> 
>     [ https://issues.apache.org/jira/browse/LUCENE-
> 7651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel&focusedCommentId=15855724#comment-15855724 ]
> 
> Uwe Schindler commented on LUCENE-7651:
> ---------------------------------------
> 
> I backported this change to Lucene 5.5.4, because otherwise we cannot run
> the build with Java 8 anymore. The problem is the following: Java 7's
> Javadocs do not add a "script.js" file to the Javadocs output, so this fix 
> injects
> the javadocs, but because a "script.js" is nowhere referenced in the HTML
> files, prettyprint is not loaded.
> 
> We have the following possibilities:
> - revert this backport commit, but it prevents smoketester from suceeding (as
> it checks also Java 8). It also makes it impossible to build the 5.5.4 release
> with Java 8
> - add more hacks to inject a script tag into the head element, but that's 
> really
> complicated as you have to do it in every HTML file!
> - ignore the fact that Javadocs do not code-prettyprint correctly anymore in
> Java 7. The Javadocs are fine, just the code exaples are no longer syntax
> highlighted.
> 
> I'd go for the third item. Any comments? If we go this route, I will add a
> comment to the Changelog that prettyprinting Javadocs is no longer working,
> if docs are build with Java 7.
> 
> > Javadocs build fails with Java 8 update 121
> > -------------------------------------------
> >
> >                 Key: LUCENE-7651
> >                 URL: https://issues.apache.org/jira/browse/LUCENE-7651
> >             Project: Lucene - Core
> >          Issue Type: Bug
> >          Components: general/javadocs
> >    Affects Versions: 6.4
> >         Environment: Java 8 update 121
> >            Reporter: Uwe Schindler
> >            Assignee: Uwe Schindler
> >            Priority: Critical
> >              Labels: Java8
> >             Fix For: 6.x, master (7.0), 6.5, 6.4.1
> >
> >         Attachments: LUCENE-7651.patch, LUCENE-7651.patch, LUCENE-
> 7651.patch, LUCENE-7651.patch
> >
> >
> > Oracle released the recent Java 8 security update (u121). The Jenkins builds
> fail with the following error while building the Javadocs:
> > {noformat}
> >   [javadoc] Constructing Javadoc information...
> >   [javadoc] javadoc: error - Argument for -bottom contains JavaScript.
> >   [javadoc] Use --allow-script-in-comments to allow use of JavaScript.
> >   [javadoc] 1 error
> > {noformat}
> > This is caused by the Javascript added to pretty-print code examples. We
> load this in the page footer "{{<bottom>}}" parameter.
> > Surely, it will be posisble to simply add the mentioned argument, but this
> will break builds with earlier Java 8 versions.
> > This is nowhere documented, I haven't seen any documentation about this
> flag nowhere, so I assume this is a bug in Java. They can't change or add
> command line parameters in minor updates of Java 8. I will ask on the
> OpenJDK mailing lists if this is a bug (maybe accidentally backported from
> Java 9).
> 
> 
> 
> --
> This message was sent by Atlassian JIRA
> (v6.3.15#6346)
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to