[
https://issues.apache.org/jira/browse/LUCENE-7693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865779#comment-15865779
]
Steve Rowe commented on LUCENE-7693:
------------------------------------
+1, LGTM, diff says the native POMs are identical.
> revisit "org.apache." logic in GetMavenDependenciesTask.java
> ------------------------------------------------------------
>
> Key: LUCENE-7693
> URL: https://issues.apache.org/jira/browse/LUCENE-7693
> Project: Lucene - Core
> Issue Type: Wish
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: LUCENE-7693.patch, LUCENE-7693-step1.patch,
> LUCENE-7693-step2.patch
>
>
> Objective:
> * replace the {{... "org.apache." + ...}} logic in
> GetMavenDependenciesTask.java at
> [L399|https://github.com/apache/lucene-solr/blob/master/lucene/tools/src/java/org/apache/lucene/dependencies/GetMavenDependenciesTask.java#L399]
> and
> [L584|https://github.com/apache/lucene-solr/blob/master/lucene/tools/src/java/org/apache/lucene/dependencies/GetMavenDependenciesTask.java#L584]
> Motivation:
> * support for custom {{solr/contrib/...-myteam}} modules where the custom
> modules have dependencies between them and the package structure is
> _com.mycompany.myteam_ rather than _org.apache.solr_
> Approach:
> * step 1:
> ** in GetMavenDependenciesTask.java build a map out of all the ivy.xml files'
> info elements e.g.
> {code}
> <ivy-module version="2.0">
> <info organisation="org.apache.lucene" module="core"/>
> </ivy-module>
> {code}
> ** temporarily instrument GetMavenDependenciesTask.java to help determine how
> the info element mappings differ from the current in-code logic
> * step 2:
> ** adjust selected ivy.xml files to minimise differences
> * step 3:
> ** switch over to 'new way' logic where this matches current in-code logic
> ** remove the temporary instrumentation
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
