[ 
https://issues.apache.org/jira/browse/LUCENE-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868078#comment-15868078
 ] 

Adrien Grand commented on LUCENE-7449:
--------------------------------------

The patch looks good overall, just some minor style comments:
 - can you use {{IntPredicate}} rather than {{Predicate<Integer>}}?
 - can you move the big switch statement in {{visit(int docID, byte[] leaf)}} 
to the constructor of the {{IntersectVisitor}} so that we do not have to 
re-choose the appropriate predicate for every document?

> Add CROSSES query support to RangeField
> ---------------------------------------
>
>                 Key: LUCENE-7449
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7449
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Nicholas Knize
>         Attachments: LUCENE-7449.patch, LUCENE-7449.patch
>
>
> {{RangeField}} currently supports {{INTERSECTS}}, {{WITHIN}}, and 
> {{CONTAINS}} query behavior. This feature adds support for an explicit 
> {{CROSSES}} query. Unlike {{INTERSECT}} and {{OVERLAP}} queries the 
> {{CROSSES}} query finds any indexed ranges whose interior (within range) 
> intersect the interior AND exterior (outside range) of the query range.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to