[ 
https://issues.apache.org/jira/browse/SOLR-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871484#comment-15871484
 ] 

Robert Alexandersson commented on SOLR-10134:
---------------------------------------------

I have added a test and noticed that the code had changed quite alot in this so 
needed to add change more to support the EmbeddedSolrServer requests. It does 
seem like you are in need of adding more tests in general for the 
EmbeddedSolrServer as it seems to get lost in the main "http" flows.  The tests 
and code changes can be found in PR on github, 
https://github.com/apache/lucene-solr/pull/158 

> EmbeddedSolrServer does not support SchemaAPI
> ---------------------------------------------
>
>                 Key: SOLR-10134
>                 URL: https://issues.apache.org/jira/browse/SOLR-10134
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Server, SolrJ
>    Affects Versions: 6.4.1
>            Reporter: Robert Alexandersson
>              Labels: test-driven
>         Attachments: SOLR-10134.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The EmbeddedSolrServer server does not support calls to the POST methods of 
> SchemaAPI using SolRJ api. The reason is that the httpMethod param is never 
> set by the EmbeddedSolrServer#request(SolrRequest, String) and this is later 
> required by the SchemaHandler class that actually performs the call at 
> SchemaHandler#handleRequestBody(SolrQueryRequest, SolrQueryResponse). 
> Proposal is to enhance the EmbeddedSolrServer to forward the httpMethod at 
> aprox row 174 with the following: "req.getContext().put("httpMethod", 
> request.getMethod().name());". This change requires the Factory methods of 
> SolrJ to add the intended method to be used example : new 
> SchemaRequest.AddField(....) should append the POST method similar to how the 
> SchemaRequest.Field appends the GET method.
> I have written a separate EmbeddedSolrServer that replaces the one in SolR. 
> It works for now and fields can be created on the fly using the SchemaAPI of 
> the solrj client, but would like to be able to remove this workaround.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to