[ 
https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875705#comment-15875705
 ] 

Jim Ferenczi commented on LUCENE-7699:
--------------------------------------

It looks good [~mattweber]
In analyzeGraphPhrase you check getAutoGenerateMultiTermSynonymsPhraseQuery 
when a side path is built. Is it intended ? I don't understand what the 
non-quoted query built by createSpanQuery is supposed to represent. 
On a different note I also wonder if we should keep the specialized GraphQuery. 
IMO it's not useful anymore especially if we use span queries for quoted query. 



> Apply graph articulation points optimization to phrase graph queries
> --------------------------------------------------------------------
>
>                 Key: LUCENE-7699
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7699
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Matt Weber
>         Attachments: LUCENE-7699.patch
>
>
> Follow-up to LUCENE-7638 that applies the same articulation point logic to 
> graph phrases using span queries.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to