[
https://issues.apache.org/jira/browse/SOLR-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876884#comment-15876884
]
Amrit Sarkar commented on SOLR-10153:
-------------------------------------
Mr. Smiley,
Thank you for the feedback and glad you found the patch good enough.
Regarding _fragsize == 1_; I got that wrong for sure, thank you correcting me
out. I made some wrong assertions on the fragment size specified which doesn't
make sense, was trying to optimise considering the code below in
getBreakIterator(String field):
{code:xml}
312: if (fragsize <= 1 || baseBI instanceof WholeBreakIterator) { // no
real minimum size
313: return baseBI;
314: }
{code}
I put the piece of code back where it belong. PF the updated patch.
I will also appreciate your inputs on SOLR-10152, CustomSeparatorBreakIterator
for PostingsSolrHighlighter.
Thanks,
Amrit Sarkar
> UnifiedSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)
> -----------------------------------------------------------------------------
>
> Key: SOLR-10153
> URL: https://issues.apache.org/jira/browse/SOLR-10153
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: highlighter
> Reporter: Amrit Sarkar
> Attachments: SOLR-10153.patch
>
>
> Lucene 5.3 added a CustomSeparatorBreakIterator (see LUCENE-6485)
> UnifiedSolrHighlighter should support *CustomSeparatorBreakIterator* along
> with existing ones, WholeBreakIterator etc.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
