[
https://issues.apache.org/jira/browse/SOLR-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878478#comment-15878478
]
ASF GitHub Bot commented on SOLR-10190:
---------------------------------------
GitHub user jwoschitz opened a pull request:
https://github.com/apache/lucene-solr/pull/160
SOLR-10190 - Potential NPE in CloudSolrClient when reading stale alias
Added a test case and potential solution to guard against NPE, see JIRA
issue https://issues.apache.org/jira/browse/SOLR-10190
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jwoschitz/lucene-solr jira/solr-10190
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #160
----
commit ee8409b2cf5b983211854a289b58f82d3775da4a
Author: Janosch Woschitz <[email protected]>
Date: 2017-02-22T15:26:29Z
SOLR-10190 - Added a test case and potential solution to guard against NPE
in CloudSolrClient
----
> Potential NPE in CloudSolrClient when reading stale alias
> ---------------------------------------------------------
>
> Key: SOLR-10190
> URL: https://issues.apache.org/jira/browse/SOLR-10190
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: clients - java, SolrJ
> Affects Versions: 5.5, 6.x, master (7.0)
> Reporter: Janosch Woschitz
>
> The CloudSolrClient raises a NullPointerException when CloudSolrClient::add
> is invoked and pointed to an alias which references a collection which does
> not exist anymore.
> {code}
> java.lang.NullPointerException
> at __randomizedtesting.SeedInfo.seed([1D00539A964E5C5D:D7D145363AD5CCA]:0)
> at
> org.apache.solr.client.solrj.impl.CloudSolrClient.requestWithRetryOnStaleState(CloudSolrClient.java:1078)
> at
> org.apache.solr.client.solrj.impl.CloudSolrClient.request(CloudSolrClient.java:1042)
> at org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:160)
> at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:106)
> at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:71)
> at org.apache.solr.client.solrj.SolrClient.add(SolrClient.java:85)
> {code}
> This is a rather unexpected since the CloudSolrClient usually raises a
> SolrException containing a descriptive error message (e.g. "Collection not
> found: xyz") when a collection cannot be resolved.
> In general this error condition could be triggered also by other edge cases
> since CloudSolrClient::getDocCollection might return null but the code
> following that invocation is not guarded against null values.
> {code}
> // track the version of state we're using on the client side using
> the _stateVer_ param
> DocCollection coll = getDocCollection(requestedCollection, null);
> int collVer = coll.getZNodeVersion();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
