[
https://issues.apache.org/jira/browse/SOLR-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879134#comment-15879134
]
Erick Erickson commented on SOLR-10186:
---------------------------------------
Gah, any class found in IntelliJ by the cmd-o key sequence MUST be in Solr,
right? My mistake.
Yes, let's open the JIRA in LUCENE if for no other reason than have the Lucene
guys notice and comment if they don't like the idea.
Erick
P.S. On a quick glance I notice these lines still in the code:
if (!args.isEmpty()) {
throw new IllegalArgumentException("Unknown parameters: " + args);
}
So I think if you specify a tag in the schema file it'll throw an error here.
It'd be good to have a test here I should think.
> Allow CharTokenizer-derived tokenizers and KeywordTokenizer to configure the
> max token length
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-10186
> URL: https://issues.apache.org/jira/browse/SOLR-10186
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Priority: Minor
> Attachments: SOLR-10186.patch
>
>
> Is there a good reason that we hard-code a 256 character limit for the
> CharTokenizer? In order to change this limit it requires that people
> copy/paste the incrementToken into some new class since incrementToken is
> final.
> KeywordTokenizer can easily change the default (which is also 256 bytes), but
> to do so requires code rather than being able to configure it in the schema.
> For KeywordTokenizer, this is Solr-only. For the CharTokenizer classes
> (WhitespaceTokenizer, UnicodeWhitespaceTokenizer and LetterTokenizer)
> (Factories) it would take adding a c'tor to the base class in Lucene and
> using it in the factory.
> Any objections?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
