[
https://issues.apache.org/jira/browse/SOLR-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880104#comment-15880104
]
Uwe Schindler commented on SOLR-9450:
-------------------------------------
The line {{<property name="useLocalJavadocUrl" value=""/>}} in
{{define-solr-javadoc-url}} is obsolete, as this is not used here. It is only
for Lucene to override some stuff (it disables SNAPSHOT mode and is Jenkins
related). We may do the same for Solr, but this would require to move the
"-SNAPSHOT" check to the groovy script and remove it from the XSL. My
suggestion would be to use the same logic like for the Lucene Javadocs URL
(same "if" statement) and if the URL is offline, leave it empty. The XSL would
just do a check on empty solr-javadoc-url (if its empty) - and not the version
- and then print the 2 variants (online or offline).
In addition, The first line of the groovy script misses type declaration,
should be {{String version = ...}}. It works, but is like Javascript variables
without "var".
I can slightly modify the patch and upload a new one, ok?
> Link to online Javadocs instead of distributing with binary download
> --------------------------------------------------------------------
>
> Key: SOLR-9450
> URL: https://issues.apache.org/jira/browse/SOLR-9450
> Project: Solr
> Issue Type: Sub-task
> Components: Build
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Fix For: 6.5, master (7.0)
>
> Attachments: SOLR-9450.patch, SOLR-9450.patch, SOLR-9450.patch,
> SOLR-9450.patch
>
>
> Spinoff from SOLR-6806. This sub task will replace the contents of {{docs}}
> in the binary download with a link to the online JavaDocs. The build should
> make sure to generate a link to the correct version. I believe this is the
> correct tamplate: http://lucene.apache.org/solr/6_2_0/
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
