[
https://issues.apache.org/jira/browse/SOLR-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884271#comment-15884271
]
Uwe Schindler commented on SOLR-10158:
--------------------------------------
bq. LuceneTestCase.assumeWorkingMmap method is testing the directory, which is
already tested, not the factory.
You misunderstood that. The assumeWorkingMmap is a check that unmapping works
at all. If not, it disables the test - and that is what I wanted. Your test
does not work if unmapping does not work, so it must be disabled if this is the
case (On windows without unmapping the test Framework will complain about still
open files after core startup...). assumeWorkingMmap takes care of that.
Nevertheless, the test is not needed, lets go without it! I will commit the
no-test patch soon. Thanks!
> MMapDirectoryFactory support for "preload" option (LUCENE-6549)
> ---------------------------------------------------------------
>
> Key: SOLR-10158
> URL: https://issues.apache.org/jira/browse/SOLR-10158
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
> Reporter: Amrit Sarkar
> Assignee: Uwe Schindler
> Priority: Trivial
> Attachments: SOLR-10158-no-test-cases.patch, SOLR-10158.patch
>
>
> Lucene 5.3 added a new preload option to MMapDirectory (see LUCENE-6549)
> MMapDirectoryFactory needs to be updated to offer this as a config option.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
