[ 
https://issues.apache.org/jira/browse/LUCENE-5143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888151#comment-15888151
 ] 

Jan Høydahl commented on LUCENE-5143:
-------------------------------------

Ah, thanks :)

I think we should stop copying this file to KEYS - see the last chapter of this 
page http://home.apache.org/keys/ - it says explicitly that it cannot be used 
as-is for a KEYS file since it will not contain all needed keys.

So if we agree that we do not need KEYS file for each version release, only one 
on top-level, then we can add to the Release TODO a bullet about checking that 
your own key is in the current KEYS file, and if not add it. It should be 
sufficient, since we only require keys of committers who have signed a release, 
so an RM who has done a release simply needs to verify that his current key is 
on the list.

> rm or formalize dealing with "general" KEYS files in our dist dir
> -----------------------------------------------------------------
>
>                 Key: LUCENE-5143
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5143
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Hoss Man
>
> At some point in the past, we started creating a snapshots of KEYS (taken 
> from the auto-generated data from id.apache.org) in the release dir of each 
> release...
> http://www.apache.org/dist/lucene/solr/4.4.0/KEYS
> http://www.apache.org/dist/lucene/java/4.4.0/KEYS
> http://archive.apache.org/dist/lucene/java/4.3.0/KEYS
> http://archive.apache.org/dist/lucene/solr/4.3.0/KEYS
> etc...
> But we also still have some "general" KEYS files...
> https://www.apache.org/dist/lucene/KEYS
> https://www.apache.org/dist/lucene/java/KEYS
> https://www.apache.org/dist/lucene/solr/KEYS
> ...which (as i discovered when i went to add my key to them today) are stale 
> and don't seem to be getting updated.
> I vaguely remember someone (rmuir?) explaining to me at one point the reason 
> we started creating a fresh copy of KEYS in each release dir, but i no longer 
> remember what they said, and i can't find any mention of a reason in any of 
> the release docs, or in any sort of comment in buildAndPushRelease.py
> we probably do one of the following:
>  * remove these "general" KEYS files
>  * add a disclaimer to the top of these files that they are legacy files for 
> verifying old releases and are no longer used for new releases
>  * ensure these files are up to date stop generating per-release KEYS file 
> copies
>  * update our release process to ensure that the general files get updated on 
> each release as well



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to