[ 
https://issues.apache.org/jira/browse/LUCENE-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888703#comment-15888703
 ] 

Paul Elschot commented on LUCENE-7715:
--------------------------------------

bq. ... how it deals with the initial state that all sub spans have a start 
position of -1.

There is no need for that, the intermediate data structure is a priority queue 
that is not a Spans itself.

If the names of this priority queue (SpanTotalLengthEndPositionWindow) and its 
methods (startDocument/nextPosition) are misleading, they need to be improved.

The core search tests and precommit pass.


> Simplify NearSpansUnordered
> ---------------------------
>
>                 Key: LUCENE-7715
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7715
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: master (7.0)
>            Reporter: Paul Elschot
>            Priority: Minor
>         Attachments: LUCENE-7715.patch
>
>
> {code}
> git diff --stat master...
>  .../spans/NearSpansUnordered.java       | 211 ++++---------
>  1 file changed, 59 insertions(+), 152 deletions(-)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to