[ 
https://issues.apache.org/jira/browse/SOLR-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036038#comment-13036038
 ] 

Simon Willnauer commented on SOLR-1942:
---------------------------------------

some minor comments:

 * s/nothit/nothing in  // make sure we use the default if nothit is configured
 * add javadoc to CodecProvider#hasFieldCodec(String)
 * SchemaCodecProvider should maybe add its name in toString() and not just 
delegate
 * Maybe we should note in the CHANGES.TXT that IndexReaderFactory now has a 
CodecProvider that should be passed to IR#open()

otherwise it looks good though!


> Ability to select codec per field
> ---------------------------------
>
>                 Key: SOLR-1942
>                 URL: https://issues.apache.org/jira/browse/SOLR-1942
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.0
>            Reporter: Yonik Seeley
>            Assignee: Grant Ingersoll
>             Fix For: 4.0
>
>         Attachments: SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, 
> SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, SOLR-1942.patch, 
> SOLR-1942.patch, SOLR-1942.patch
>
>
> We should use PerFieldCodecWrapper to allow users to select the codec 
> per-field.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to