[
https://issues.apache.org/jira/browse/SOLR-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899758#comment-15899758
]
Christine Poerschke commented on SOLR-10178:
--------------------------------------------
bq. ... Still, I'm unhappy about having to hack this way; ...
I think it would be fair to consider your solution not as a 'hack' but as a
temporary 'pragmatic solution' since with SOLR-8668 (when we get to it,
hopefully before and in time for the 7.0.0 release) the non-factory code paths
will go away and with it the 'hack' will go away too.
> TestInPlaceUpdatesDistrib unable to use NoMergePolicy[Factory] on branch_6x
> ---------------------------------------------------------------------------
>
> Key: SOLR-10178
> URL: https://issues.apache.org/jira/browse/SOLR-10178
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Ishan Chattopadhyaya
> Assignee: Ishan Chattopadhyaya
> Fix For: master (7.0), branch_6x
>
>
> TestInPlaceUpdatesDistrib depends on consistent segments to track docIds to
> assert in-place updates.
> Towards that, NoMergePolicy is best suited and working fine on master (by
> defining it using NoMergePolicyFactory).
> This doesn't work with just the MergePolicy
> (systemSetPropertySolrTestsMergePolicy()), since NoMergePolicy is a singleton
> and doesn't have a constructor. Setting only a NoMergePolicyFactory
> (systemSetPropertySolrTestsMergePolicyFactory()) seems to take no effect and
> falls back on RandomMergePolicyFactory. As a result, this test cannot use the
> NoMergePolicy[Factory].
> Here's the corresponding test failure:
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/19012/
> -Seems to me that SOLR-8668 needs to be backported to branch_6x for this test
> to work, or some other stopgap hack needs to be put in place to make it work
> before SOLR-8668 is backported. [~cpoerschke], WDYT?-
> Edit: This is also valid for master. ^
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
