[
https://issues.apache.org/jira/browse/SOLR-10235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900060#comment-15900060
]
Mikhail Khludnev commented on SOLR-10235:
-----------------------------------------
I have this commit locally. {{precommit}} just failed to me
{quote}
-check-forbidden-all:
[forbidden-apis] Reading bundled API signatures: jdk-unsafe-1.8
[forbidden-apis] Reading bundled API signatures: jdk-deprecated-1.8
[forbidden-apis] Reading bundled API signatures: jdk-non-portable
[forbidden-apis] Reading bundled API signatures: jdk-reflection
[forbidden-apis] Reading bundled API signatures: commons-io-unsafe-2.5
[forbidden-apis] Reading API signatures:
/Users/khludnevm/lucene-solr/lucene/tools/forbiddenApis/base.txt
[forbidden-apis] Reading API signatures:
/Users/khludnevm/lucene-solr/lucene/tools/forbiddenApis/servlet-api.txt
[forbidden-apis] Reading API signatures:
/Users/khludnevm/lucene-solr/lucene/tools/forbiddenApis/solr.txt
[forbidden-apis] Loading classes to check...
[forbidden-apis] Scanning classes for violations...
[forbidden-apis] Forbidden class/interface use: java.util.logging.Logger [Use
slf4j classes instead]
[forbidden-apis] in
org.apache.solr.handler.dataimport.TestJdbcDataSource$MockDriver
(TestJdbcDataSource.java, method declaration of 'getParentLogger()')
{quote}
beware
> fix last TestJdbcDataSource / mock issue with java9
> ---------------------------------------------------
>
> Key: SOLR-10235
> URL: https://issues.apache.org/jira/browse/SOLR-10235
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Assignee: Uwe Schindler
> Labels: java9
> Fix For: 6.5, master (7.0)
>
> Attachments: SOLR-10235.patch, SOLR-10235.patch, SOLR-10235.patch,
> SOLR-10235.patch, SOLR-10235.patch
>
>
> The way TestJdbcDataSource was converted to use Mockito in SOLR-9966 still
> left one outstanding test that was incompatible with Java9:
> {{testRetrieveFromDriverManager()}}
> The way this test worked with mock classes was also sketchy, but under java9
> (even with Mockito) the attempt at using class names to resolve things in the
> standard SQL DriverManager isn't viable.
> It seems like any easy fix is to create _real_ class (with a real/fixed
> classname) that acts as a wrapper around a mockito "Driver" instance just for
> the purposes of checking that the DriverManaer related code is working
> properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
