[
https://issues.apache.org/jira/browse/LUCENE-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Woodward updated LUCENE-7737:
----------------------------------
Attachment: LUCENE-7737.patch
Here's a patch. It's quite meaty, so here's a summary:
spatial-extras uses ValueSources in three ways:
* Predicate objects to check if a particular document matches a given shape.
I've replaced this with a ShapePredicate, which implements a TwoPhaseIterator.
* Distance sources for sorting and scoring. These can be replaced directly by
DoubleValuesSources
* Object sources that provide an indexed Shape object per-document. I've added
ShapeValuesSource and ShapeValues classes here to cover this.
This simplifies some things, and improves type-safety. I need to run some
benchmarks to ensure that I haven't inadvertently slowed stuff down anywhere.
[~dsmiley] this is mostly your code, what do you think?
> Remove spatial-extras dependency on queries
> -------------------------------------------
>
> Key: LUCENE-7737
> URL: https://issues.apache.org/jira/browse/LUCENE-7737
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Priority: Minor
> Attachments: LUCENE-7737.patch
>
>
> The spatial-extras module uses ValueSources for a number of different
> purposes, requiring a dependency on the queries module. I'd like to try
> using core-only interfaces here instead, allowing us to remove the dependency
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
