Hi Shawn, For what it's worth, I'm using Idea FindBugs plugin. There is some overlap between Idea warnings and Findbugs, but there's also a number of warnings unique to each of them. I'm starting with performance warnings, because the benefit of fixing them is usually non-controversial. I don't plan to add any suppressions, because it would require adding a compile-time dependency on Findbugs, and also because I'm not a fan of hiding problems. Regards, Daniel
2017-03-12 21:53 GMT+01:00 Shawn Heisey <[email protected]>: > On 3/11/2017 4:48 PM, Daniel Jeliński wrote: > > I started fixing code issues reported by Findbugs; right now it is > > reporting 4000+ issues in lucene/solr repository. I could use some > > guidance: > > 1) Will one JIRA issue be sufficient to cover all Findbugs-related > > items, or should I raise separate items for distinct problems reported > > by Findbugs? I raised LUCENE-7739 as a catch-all issue, but I can > > split it if that's preferred. > > 2) My plan is to fix trivial issues first, then work on the harder > > ones. I already sent a patch to fix issues related to unnecessary > > boxing/unboxing when parsing strings. That patch covers the entire > > codebase, but in my opinion it's fairly straightforward. Is that > > acceptable, or should I split the patch somehow? Like, lucene/solr, or > > one file at a time, or one issue at a time or... > > I wonder how much overlap there is between FindBugs and IDE warnings > from Eclipse and Idea. > > I have wanted to tackle the thousands of warnings that Eclipse shows me > for quite some time, but I don't really know how to tell when the > warning should be taken seriously and when it should be suppressed. > When I have mentioned it before, nobody else really has any interest, > doesn't consider it to be a problem. > > Thanks, > Shawn > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
