[ 
https://issues.apache.org/jira/browse/LUCENE-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925030#comment-15925030
 ] 

Keith Laban edited comment on LUCENE-7671 at 3/14/17 9:21 PM:
--------------------------------------------------------------

Because i've added some {{oldSingleSegmentNames}} with this commit, 
{{TestBackwardsCompatibility.testUpgradeOldSingleSegmentIndexWithAdditions}} 
now fails after rebasing LUCENE-7703 because of this line 
https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java#L2657
 

Prior to this commit this test effectively does nothing as there were no old 
single segment test files. This failure should be addressed outside the scope 
of this ticket.


was (Author: k317h):
Because i've added some {{oldSingleSegmentNames}} with this commit, 
{{TestBackwardsCompatibility.testUpgradeOldSingleSegmentIndexWithAdditions}} 
now fails after rebasing LUCENE-7703 because of this line 
https://github.com/apache/lucene-solr/blob/master/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java#L2657
 

Prior to this commit this effectively does nothing as there were no old single 
segment files. This failure should be addressed outside the scope of this 
ticket.

> Enhance UpgradeIndexMergePolicy with additional options
> -------------------------------------------------------
>
>                 Key: LUCENE-7671
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7671
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Keith Laban
>
> Enhance UpgradeIndexMergePolicy to be a MergePolicy that can be used outside 
> the scope the IndexUpgrader.
> The enhancement aims to allow the UpgradeIndexMergePolicy to:
> 1) Delegate normal force merges to the underlying merge policy
> 2) Enable a flag that will explicitly tell UpgradeIndexMergePolicy when it 
> should start looking for upgrades.
> 3) Allow new segments to be considered to be merged with old segments, 
> depending on underlying MergePolicy.
> 4) Be configurable for backwards compatibility such that only segments 
> needing an upgrade would be considered when merging, no explicit upgrades.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to