[ 
https://issues.apache.org/jira/browse/LUCENE-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036631#comment-13036631
 ] 

Chris Male commented on LUCENE-2883:
------------------------------------

{quote}
So the goal here is to make the top-level searcher (IR) visible to the
FQ's getValues? I think this pre-dated the cutover to
AtomicReaderContext, which now provides the top reader? Maybe this
isn't needed anymore...?
{quote}

Its very intentional (as Yonik has pointed out).  It allows any Querys in the 
ValueSources to be weighted.

{quote}
Though QueryValueSource needs a searcher (but, seems to make one, from
the top reader, if it wasn't provided one).
{quote}

Is this desirable? IndexSearcher is pretty thin I know but is it fast enough to 
create that it has a nominal effect? If its faster than passing down the 
IndexSearcher then maybe its a good idea for anybody wanting an IndexSearcher 
to do this.

{quote}
Good question... maybe we can do this on a branch?
{quote}

Absolutely, can you create one?


> Consolidate Solr  & Lucene FunctionQuery into modules
> -----------------------------------------------------
>
>                 Key: LUCENE-2883
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2883
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/search
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>              Labels: gsoc2011, lucene-gsoc-11, mentor
>             Fix For: 4.0
>
>         Attachments: LUCENE-2883.patch
>
>
> Spin-off from the [dev list | 
> http://www.mail-archive.com/[email protected]/msg13261.html]  

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to