[ 
https://issues.apache.org/jira/browse/LUCENE-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Rowe updated LUCENE-7748:
-------------------------------
    Attachment: LUCENE-7748.patch

Slightly modified patch, to report all collected errors on both DOAP files, 
rather than just the first error.

I ran the patched {{buildAndPushRelease.py}} against {{master}}, {{branch_6x}}, 
all the {{branch_6_\*}} release branches, and {{branch_5_5}}, and all pass the 
DOAP checks except for {{branch_6_0}} through {{branch_6_3}}, which report 
(e.g. from {{branch_6_0}}):

{noformat}
Prepare release...
  git pull...
  git clone is clean
  git rev: 8ed9528b8e3288f02882eef570b20cf420d01b3c
  Check DOAP files
Traceback (most recent call last):
  File "../lucene-solr-3/dev-tools/scripts/buildAndPushRelease.py", line 313, 
in <module>
    main()
  File "../lucene-solr-3/dev-tools/scripts/buildAndPushRelease.py", line 294, 
in main
    rev = prepare(c.root, c.version, c.key_id, c.key_password)
  File "../lucene-solr-3/dev-tools/scripts/buildAndPushRelease.py", line 98, in 
prepare
    checkDOAPfiles(version)
  File "../lucene-solr-3/dev-tools/scripts/buildAndPushRelease.py", line 170, 
in checkDOAPfiles
    % '\n'.join(errorMessages))
RuntimeError: 
ERROR: Missing revision(s) in dev-tools/doap/lucene.rdf: 5.5.4
ERROR: Missing revision(s) in dev-tools/doap/solr.rdf: 5.5.4
(Hint: copy/paste from the stable branch version of the file(s).)
{noformat}

When I disable the checks for a dirty checkout and remove revisions 5.3.2 and 
5.5.3 from {{lucene.rdf}}, the error message changes to:

{noformat}
ERROR: Missing revision(s) in dev-tools/doap/lucene.rdf: 5.3.2, 5.5.3, 5.5.4
ERROR: Missing revision(s) in dev-tools/doap/solr.rdf: 5.5.4
{noformat}

I think it's ready to go; committing shortly.

> buildAndPushRelease.py should fail if the project DOAP files are missing 
> releases that are less than the release being produced
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7748
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7748
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Steve Rowe
>            Priority: Minor
>         Attachments: LUCENE-7748.patch, LUCENE-7748.patch
>
>
> I wrote on the 6.4.1 release vote thread:
> {quote}
> One minor problem with both Changes.html files: there is no release date on 
> the 6.4.0 release section.  The 6.4.0 release section was never added to the 
> DOAP files under dev-tools/doap/ on branch_6_4.  I’ll think about a way of 
> automating a test to prevent this in the future.  In the meantime, I’ll add a 
> reminder to sanity check the DOAP files before a release to the ReleaseToDo.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to