[
https://issues.apache.org/jira/browse/SOLR-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935341#comment-15935341
]
David Smiley commented on SOLR-10304:
-------------------------------------
I'm glad you like it Ishan :-)
I have no convictions about where to put these things... but one option is
{{SolrDocumentFetcher}}. Fetching & conversion / decoration could be its
scope. If it's _not_ SDF, then perhaps SDF's scope should be more narrow as to
not include {{decorateDocValueFields}}. I'm kind of inclined to put all this
stuff in SDF.
> Refactor Document/Stored-field handling out of SolrIndexSearcher
> ----------------------------------------------------------------
>
> Key: SOLR-10304
> URL: https://issues.apache.org/jira/browse/SOLR-10304
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Attachments: SOLR_10304_SolrDocumentFetcher.patch
>
>
> SolrIndexSearcher is nearly 3 thousand lines of code. A sizable part of it
> pertains to Document handling, including various stored-field concerns and
> docValue substitutions (docValueAsStored related). There are already
> comments marking the start and end of this part of SolrIndexSearcher, plus
> there some fields and their initialization that are only in support of those
> methods. I propose that all of this go to a new companion class
> {{SolrDocumentFetcher}}. SolrIndexSearcher can add a getter for it, and where
> applicable existing callers can call to this instead. "Override"'s will need
> to stay of course.
> ( Originally proposed in SOLR-10286 )
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
