[
https://issues.apache.org/jira/browse/SOLR-10249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936999#comment-15936999
]
ASF GitHub Bot commented on SOLR-10249:
---------------------------------------
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/169#discussion_r107513516
--- Diff: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java ---
@@ -321,9 +369,16 @@ boolean fetchLatestIndex(boolean forceReplication,
boolean forceCoreReload) thro
try {
response = getLatestVersion();
} catch (Exception e) {
- LOG.error("Master at: " + masterUrl + " is not available. Index
fetch failed. Exception: " + e.getMessage());
- return false;
- }
+ final String errorMsg = e.getMessage();
--- End diff --
Granted e.getMessage() was what this code was doing before you made changes
but can you please use e.toString() instead? IMO, e.getMessage() should rarely
if ever be called instead of e.toString() because e.toString() critically
contains the name of the exception itself. The "message" alone can be unclear
without the exception class. Consider `FileNotFoundException` and there are
others.
> Allow index fetching to return a detailed result instead of a true/false value
> ------------------------------------------------------------------------------
>
> Key: SOLR-10249
> URL: https://issues.apache.org/jira/browse/SOLR-10249
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: replication (java)
> Affects Versions: 6.4.1
> Environment: Any
> Reporter: Jeff Miller
> Priority: Trivial
> Labels: easyfix, newbie
> Fix For: 6.5
>
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> This gives us the ability to see into why a replication might of failed and
> act on it if we need to. We use this enhancement for logging conditions so
> we can quantify what is happening with replication, get success rates, etc.
> The idea is to create a public static class IndexFetchResult as an inner
> class to IndexFetcher that has strings that hold statuses that could occur
> while fetching an index.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
