[ 
https://issues.apache.org/jira/browse/SOLR-10346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937063#comment-15937063
 ] 

Hoss Man commented on SOLR-10346:
---------------------------------

bq. Home link. This should be made dynamic to update automatically for each 
version the Guide applies to

the link text already pulls in the version# from a site variable, and now that 
i've committed SOLR-10342 that will match the common-build.xml specified 
version.

bq. Solr Resources. Links to Javadocs, Source code and Community page of Solr 
website. Javadoc links should be dynamic.

This is currently a little tricky -- while the "home" link text is part of the 
{{topnav.html}} template (and can refer to site variables) the template then 
loops over entries in {{topnav.yml}} for the other various links -- and there's 
no way (that i know of) to have entries in {{topnav.yml}} refer to site 
variables.

the 2 solutions i can think of:

* remove {{topnav.yml}} and hardcode the html we want in {{topnav.html}} -- 
using the existing jekyll site variable for the javadocs URL
* rename {{topnav.yml}} to {{topnav.yml.template}} and let the existing 
build.xml logic do variable substitution using ant properties (this build.xml 
logic already exists so we can use ant variables in  {{_config.yml.template}})

> Clean up static page HTML top nav
> ---------------------------------
>
>                 Key: SOLR-10346
>                 URL: https://issues.apache.org/jira/browse/SOLR-10346
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: documentation
>            Reporter: Cassandra Targett
>         Attachments: SRG-top-nav-20170322.png
>
>
> For demo purposes, the top navigation bar for the HTML version of the Ref 
> Guide includes some stuff we probably don't want in production. This should 
> be cleaned up and finalized.
> I'll attach a screenshot of the current nav for reference. It currently has 
> these sections:
> * Home link. This should be made dynamic to update automatically for each 
> version the Guide applies to
> * News. Probably don't need this? Today it goes nowhere, but it could go to 
> the News section of the Solr website.
> * Jekyll Resources. Links to stuff about Jekyll. We don't want this.
> * Solr Resources. Links to Javadocs, Source code and Community page of Solr 
> website. Javadoc links should be dynamic.
> * Feedback. Javascript to open local Mail application to send an email. 
> Currently goes to my apache.org address, which I don't want.
> * Search box. This can stay, and we can modify it to do whatever we want it 
> to do when SOLR-10299 is resolved.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to