[ 
https://issues.apache.org/jira/browse/SOLR-10304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated SOLR-10304:
--------------------------------
    Attachment: SOLR_10304_SolrDocumentFetcher.patch

Update patch with small changes pertaining to the move of 
SolrPluginUtils.docListToSolrDocumentList to the ClusteringComponent.  The test 
needed to move to which in turn required some additions to the CC's schema.xml.

All tests pass and ant precommit.  I'll commit this later today.

Further consolidation/moving around relative to RealTimeGetComponent can happen 
in another issue.

> Refactor Document/Stored-field handling out of SolrIndexSearcher
> ----------------------------------------------------------------
>
>                 Key: SOLR-10304
>                 URL: https://issues.apache.org/jira/browse/SOLR-10304
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Assignee: David Smiley
>         Attachments: SOLR_10304_SolrDocumentFetcher.patch, 
> SOLR_10304_SolrDocumentFetcher.patch
>
>
> SolrIndexSearcher is nearly 3 thousand lines of code.  A sizable part of it 
> pertains to Document handling, including various stored-field concerns and 
> docValue substitutions (docValueAsStored related).  There are already 
> comments marking the start and end of this part of SolrIndexSearcher, plus 
> there some fields and their initialization that are only in support of those 
> methods.  I propose that all of this go to a new companion class 
> {{SolrDocumentFetcher}}. SolrIndexSearcher can add a getter for it, and where 
> applicable existing callers can call to this instead.  "Override"'s will need 
> to stay of course.
> ( Originally proposed in SOLR-10286 )



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to