[
https://issues.apache.org/jira/browse/LUCENE-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Jelinski updated LUCENE-7754:
------------------------------------
Attachment: LUCENE-7754.patch
The patch should be source and binary compatible with Lucene clients, as the
modified classes are not visible outside Lucene's code.
ConstantScoreQuery$ConstantBulkScorer is protected, but the outer class is
final. JaspellTernarySearchTrie$TSTNode is protected final. The remaining
nested classes are private, package-local or test.
There's a number of public classes with modified signatures in Solr. I'm not
sure if I their signatures can be changed, if not, I may need to remove them
from patch.
There are a few more classes that could be made static after LUCENE-7753 is
implemented.
> Findbugs: nested class should be static
> ---------------------------------------
>
> Key: LUCENE-7754
> URL: https://issues.apache.org/jira/browse/LUCENE-7754
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Daniel Jelinski
> Priority: Minor
> Attachments: LUCENE-7754.patch
>
>
> http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
