[ 
https://issues.apache.org/jira/browse/LUCENE-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945164#comment-15945164
 ] 

Adrien Grand commented on LUCENE-7753:
--------------------------------------

Beware that your patch modified some autogenerated files, like the surround 
query parser. Also could you fix the naming conventions for some variables that 
you made static? We usually use uppercase for constants.

> Findbugs: mark certain final fields static
> ------------------------------------------
>
>                 Key: LUCENE-7753
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7753
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Daniel Jelinski
>            Priority: Minor
>         Attachments: LUCENE-7753.patch
>
>
> http://findbugs.sourceforge.net/bugDescriptions.html#SS_SHOULD_BE_STATIC



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to