[ 
https://issues.apache.org/jira/browse/LUCENE-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945863#comment-15945863
 ] 

Adrien Grand commented on LUCENE-7756:
--------------------------------------

Thanks for having a look! So say you have an index that was created with 
version X.Y and then you call addIndexes with an index that was created with 
version X.Z. What should be the created version after addIndexes has been 
called? Do you think we should just ignore the addIndexes call and retain X.Y 
as a created version, or maybe take the min or something?

Something else that I am considering, is to add the version of the oldest 
segment that contributed to a segment through merges, in addition to the index 
created version (major). This might address your concern if it is mainly about 
losing information that might be useful for debugging purposes?

> Only record the major that was used to create the index rather than the full 
> version
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7756
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7756
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-7756.patch
>
>
> LUCENE-7703 added information about the Lucene version that was used to 
> create the index to the segment infos. But since there is a single creation 
> version, it means we need to reject calls to addIndexes that can mix indices 
> that have different creation versions, which might be seen as an important 
> regression by some users. So I have been thinking about only recording the 
> major version that was used to create the index, which is still very valuable 
> information and would allow us to accept calls to addIndexes when all merged 
> indices have the same major version. This looks like a better trade-off to me.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to