[
https://issues.apache.org/jira/browse/SOLR-10387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947835#comment-15947835
]
Erick Erickson commented on SOLR-10387:
---------------------------------------
Ah, thanks. This may well be the recent test failures that I was about to try
to track down. Figured it would be something to do with file separators. I just
did a visual check and I think I've corrected the problems. All of the
remaining references to forward slash are ZooKeeper paths which don't have this
problem.
I don't have access to Windows machines to test, so if you could do any or all
of these it would be an enormous favor:
1> try running
ant test -Dtestcase=SolrCLIZkUtilsTest -Dtests.method=testCp
-Dtests.seed=65C25EBE642D0428 -Dtests.slow=true -Dtests.locale=zh-CN
-Dtests.timezone=Indian/Comoro -Dtests.asserts=true
-Dtests.file.encoding=ISO-8859-1
That's the failing Jenkins test. I want it to fail for you too before the patch.
2> Apply the patch I'll attach to this JIRA. It's against trunk but it should
apply to 6x.
3> run the test in <1> again, I want it to succeed....
4> run through the scenario I outlined in SOLR-10108 on 19-Feb (here are the
steps, there's some more explanation on that JIRA):
> Create a collection on Solr, any collection will do.
> 'bin/solr zk cp -r zk:/ file:/some/dir -z localhost:2181'
> Shut down Solr
> Re-initialize ZK (wipe all the data)
> 'bin/solr zk cp -r file:/some/dir/ zk:/ -z localhost:2181'
> start Solr again
> You should see everything just as it was before.
5> take a quick look at the help screens for cp ('bin/solr.cmd zk -help' should
do it).
Please feel free to attach a patch or just a corrected solr.cmd would be great
too.
Thanks!
> zkTransfer normalizes destination path incorrectly if source is a windows
> directory
> ------------------------------------------------------------------------------------
>
> Key: SOLR-10387
> URL: https://issues.apache.org/jira/browse/SOLR-10387
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: gopikannan venugopalsamy
>
> While normalizing dest it is looking only for '/' in source path but this
> will not work for windows style delimiter.
> /lucene-solr/solr/solrj/src/java/org/apache/solr/common/cloud/ZkMaintenanceUtils.java
> private static String normalizeDest(String srcName, String dstName) {
> if (dstName.endsWith("/")) { // Dest is a directory.
> int pos = srcName.lastIndexOf("/");
> if (pos < 0) {
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
