[
https://issues.apache.org/jira/browse/LUCENE-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-7756:
---------------------------------
Attachment: LUCENE-7756.patch
Here is a patch. It is a bit verbose since I had to write a new
SegmentInfoFormat in order to add the minimum version that contributed to a
segment to SegmentInfo. I tried to make the patch not lenient by raising errors
if this version is not provided for indexes created on or after Lucene 7. But
this made bw testing of old segment info formats a bit tricky, so I had to add
a hack (see SegmentInfos) that we can remove when we are on Lucene 8 in a
couple months.
I also factored the creation version, the minimum version that contributed to a
segment and the index sort in a wrapper class called IndexInfos in order to
keep the number of methods on LeafReader contained.
> Only record the major that was used to create the index rather than the full
> version
> ------------------------------------------------------------------------------------
>
> Key: LUCENE-7756
> URL: https://issues.apache.org/jira/browse/LUCENE-7756
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-7756.patch, LUCENE-7756.patch
>
>
> LUCENE-7703 added information about the Lucene version that was used to
> create the index to the segment infos. But since there is a single creation
> version, it means we need to reject calls to addIndexes that can mix indices
> that have different creation versions, which might be seen as an important
> regression by some users. So I have been thinking about only recording the
> major version that was used to create the index, which is still very valuable
> information and would allow us to accept calls to addIndexes when all merged
> indices have the same major version. This looks like a better trade-off to me.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
