[
https://issues.apache.org/jira/browse/SOLR-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037814#comment-13037814
]
Gabriele Kahlout commented on SOLR-2537:
----------------------------------------
svn diff would complain about missing directories.
I've uploaded the stripped project here[1]. Essentially there's no more
test-framework under both lucene and solr (classes moved under the cores
packages), Solr Core has been moved out of solr/src into a solr/core, and
webapp has been moved to solr/webapp a la par with core.
>From the core's pom.xml I've commented:
<!-- <plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<execution>
<id>add-test-source</id>
<phase>generate-test-sources</phase>
<goals>
<goal>add-test-source</goal>
</goals>
<configuration>
<sources>
<source>test-framework</source>
</sources>
</configuration>
</execution>
</executions>
</plugin>-->
and replaced it with:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<executions>
<execution>
<goals>
<goal>test-jar</goal>
</goals>
</execution>
</executions>
</plugin>
I've run the tests of solr core and lucene core they passed (some had errors
but they had them even before, expecting Jetty).
I hope you consider this refactoring.
[1] http://dp4j.sf.net/debug/SOLR-2537
> Refactor Solr modules structure
> -------------------------------
>
> Key: SOLR-2537
> URL: https://issues.apache.org/jira/browse/SOLR-2537
> Project: Solr
> Issue Type: Improvement
> Reporter: Gabriele Kahlout
> Priority: Minor
> Fix For: 3.1.1
>
>
> Solr modules are nested in a non-standard archeotype (e.g. Solr Core module
> is in the src dir of Solr parent).
> Also, a workaround for avoiding maven dependencies between Solr Core and
> Testframework makes it impossible to add a depenency on Solr-3.2-SNAPHOST
> (Solr Search Server) since it's packaged as a war, to import
> EmbeddedSolrServer.java, for example. It has been discussed on the mailing
> list[1].
> I've, in the mlist, suggested to "create yet one more module for Tests which
> depend on Solr Core and on the Test Framework. The org burden of that extra
> module, versus the ease of building configuration, I believe, outweights."
> However I realize there's a major drawback in that, i.e. that Solr Core will
> build without passing the tests in the other module. There're 2 solutions:
> 1. Make Solr Core a parent module that encompasses a thin Solr Core, the
> TestFramework module, and the Tests-only module;
> 2. 'Downgrade' Testframework from being a fully-fledged module by moving the
> packages under Solr Core.
> 2a. Move them under Solr Core test packages.
> 2b. move them under Solr Core src
> To me 2a is most intuitive. Those that want a dependency on Solr
> TestFramework declare it with <classifier>tests</classifier>, which packages
> only the tests, and the Solr Core classes those require.[2][3]
> The same refactoring applies to lucuene.
> [1]
> http://mail-archives.apache.org/mod_mbox/lucene-solr-user/201105.mbox/%3c2d127f11dc79714e9b6a43ac9458147fbad42...@suex07-mbx-03.ad.syr.edu%3e
> [2] http://maven.apache.org/guides/mini/guide-attached-tests.html
> [3] I've successfully used it before.
> https://code.google.com/p/memorizeasy/source/browse/MemoPlatform/persistenceui/pom.xml
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
