[
https://issues.apache.org/jira/browse/SOLR-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954612#comment-15954612
]
gopikannan venugopalsamy commented on SOLR-9217:
------------------------------------------------
[~mkhludnev]
fromSearcher.search(fromQuery, collector) gets executed inside rewrite, Is
this the inefficiency?
[JoinUtil.java]
private static Query createJoinQuery(boolean multipleValuesPerDocument,
String toField, Query fromQuery,
IndexSearcher fromSearcher, ScoreMode scoreMode, final
GenericTermsCollector collector)
throws IOException {
fromSearcher.search(fromQuery, collector);
> {!join score=..}.. should delay join to createWeight
> ----------------------------------------------------
>
> Key: SOLR-9217
> URL: https://issues.apache.org/jira/browse/SOLR-9217
> Project: Solr
> Issue Type: Improvement
> Components: query parsers
> Affects Versions: 6.1
> Reporter: Mikhail Khludnev
> Priority: Minor
> Labels: newbie, newdev
>
> {{ScoreJoinQParserPlugin.XxxCoreJoinQuery}} executes
> {{JoinUtil.createJoinQuery}} on {{rewrite()}}, but it's inefficient in
> {{filter(...)}} syntax or fq. It's better to do that in {{createWeigh()}} as
> it's done in classic Solr {{JoinQuery}}, {{JoinQParserPlugin}}.
> All existing tests is enough, we just need to assert rewrite behavior - it
> should rewrite on enclosing range query or so, and doesn't on plain term
> query.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
