[
https://issues.apache.org/jira/browse/SOLR-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954874#comment-15954874
]
Mihaly Toth commented on SOLR-10338:
------------------------------------
Sorry, next time I will have a closer look on the test failures ...
The assert is not very perfect indeed. In its current state it is sensitive for
changes and not really for failure. And now that a new recommendation is
implemented in JDK 9 the assert failed without a real bug.
The real test is that there is enough random available within reasonable time.
I am now testing a fix locally that takes 100 bytes seed and 500 random bytes
and checks that the result is available within a few seconds. On my local
machine this takes 0.3-0.4 seconds, which can be considered negligible compared
to the overall execution time of a test case. And on low entropy servers this
assert will hit if ran in blocking mode.
An alternative would be to change the assert that the algorithm is not
{{NativePRNG}}. That would be fast but would still not test the real need.
> Configure SecureRandom non blocking for tests.
> ----------------------------------------------
>
> Key: SOLR-10338
> URL: https://issues.apache.org/jira/browse/SOLR-10338
> Project: Solr
> Issue Type: Sub-task
> Reporter: Mihaly Toth
> Assignee: Mark Miller
> Fix For: master (7.0), 6.6
>
> Attachments: SOLR-10338.patch, SOLR-10338.patch, SOLR-10338.patch
>
>
> It would be best if SecureRandom could be made non blocking. In that case we
> could get rid of random entropy exhaustion issue related to all usages of
> SecureRandom.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
