[
https://issues.apache.org/jira/browse/SOLR-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955389#comment-15955389
]
Tomás Fernández Löbbe commented on SOLR-10414:
----------------------------------------------
If I'm reading the code correctly, the {{setName(...)}} inside
{{RecoveryStrategy}}'s constructor is changing it's own {{Thread#name}},
however that thread is never started, so that name is never really reflected
anywhere, the Executor is just calling {{RecoveryStrategy#run()}}. I thought
about setting the name of the current thread inside {{run()}}, however, the
executor where this is ran from already handles thread names (added with MDC
logging changes as you say).
> RecoveryStrategy should be Runnable and not a Thread
> ----------------------------------------------------
>
> Key: SOLR-10414
> URL: https://issues.apache.org/jira/browse/SOLR-10414
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Tomás Fernández Löbbe
> Priority: Minor
> Attachments: SOLR-10414.patch
>
>
> {{RecoveryStrategy}} is currently a {{Thread}} but is never started, it's
> just used as a {{Runnable}} and submitted to Executors.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
