[ 
https://issues.apache.org/jira/browse/SOLR-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955634#comment-15955634
 ] 

Christine Poerschke edited comment on SOLR-10421 at 4/4/17 7:03 PM:
--------------------------------------------------------------------

Minimal fix and test change. Ideally i would like this included in the 
stop-and-restart test case(s) to exactly capture the reported observed 
behavior, though in practice this might have to do for now with 6.5.1 release 
timeline in mind.


was (Author: cpoerschke):
Minimal fix and test change. Ideally i would like this included in the 
stop-and-restart case to exactly capture the reported observed behavior, though 
in practice this might have to do for now with 6.5.1 release timeline in mind.

> solr/contrib/ltr (MinMax|Standard)Normalizer.paramsToMap needs to save float 
> as string
> --------------------------------------------------------------------------------------
>
>                 Key: SOLR-10421
>                 URL: https://issues.apache.org/jira/browse/SOLR-10421
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 6.4.1, 6.5, 6.4.0, 6.4.2
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>         Attachments: SOLR-10421.patch
>
>
> Please see Jianxiong Dong's [solr learning_to_rank (normalizer) unmatched 
> argument type 
> issue|https://lists.apache.org/thread.html/dd7f553b28da5ea6ef55bf0059970be50fb3e2c68348ac95a749163d@%3Csolr-user.lucene.apache.org%3E]
>  email on the user mailing list for details on how this bug manifests.
> Implementation choice background:
> * If the number were to be saved as a number then {{4.2}} could be considered 
> either as a float or as a double and hence the normalizer classes would need 
> setters for both those possibilities. Equally, {{42.0}} could be saved as 
> just {{42}} which then could be either an int or a long and so again setters 
> for both possibilities would be needed. All this complexity is avoided by 
> saving the number as a string. The class has convenience float setters which 
> can be handy for use in tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to