Github user covolution commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/171#discussion_r110107074
  
    --- Diff: solr/core/src/java/org/apache/solr/handler/StreamHandler.java ---
    @@ -199,10 +200,16 @@ public void inform(SolrCore core) {
           .withFunctionName("mult", MultiplyEvaluator.class)
           .withFunctionName("sub", SubtractEvaluator.class)
           .withFunctionName("log", NaturalLogEvaluator.class)
    +
           // Conditional Stream Evaluators
           .withFunctionName("if", IfThenElseEvaluator.class)
           ;
     
    +      // Date evaluators
    --- End diff --
    
    I figured using one class (< 170 lines) to implement 11 date functions was 
preferable to lots of little classes.  Now I know there's an assumption that 1 
class = 1 function, I can re-factor to add all the extra classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to