[ https://issues.apache.org/jira/browse/SOLR-9217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961387#comment-15961387 ]
gopikannan venugopalsamy edited comment on SOLR-9217 at 4/7/17 8:28 PM: ------------------------------------------------------------------------ [~mkhludnev] Thanks again, I understood the inefficiency. [~werder] your patch works. Thanks. Attached patch [SOLR-9217.patch] was (Author: gopikannan): [~mkhludnev] Thanks again, I understood the inefficiency. [~werder] your patch works. Thanks. Attached patch. > {!join score=..}.. should delay join to createWeight > ---------------------------------------------------- > > Key: SOLR-9217 > URL: https://issues.apache.org/jira/browse/SOLR-9217 > Project: Solr > Issue Type: Improvement > Components: query parsers > Affects Versions: 6.1 > Reporter: Mikhail Khludnev > Priority: Minor > Labels: newbie, newdev > Attachments: SOLR_9217.patch, SOLR-9217.patch > > > {{ScoreJoinQParserPlugin.XxxCoreJoinQuery}} executes > {{JoinUtil.createJoinQuery}} on {{rewrite()}}, but it's inefficient in > {{filter(...)}} syntax -or fq- (!) I suppose it's {{filter()}} only problem, > not fq. It's better to do that in {{createWeigh()}} as it's done in classic > Solr {{JoinQuery}}, {{JoinQParserPlugin}}. > All existing tests is enough, we just need to assert rewrite behavior - it > should rewrite on enclosing range query or so, and doesn't on plain term > query. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org