On Mon, May 23, 2011 at 11:08 AM, Shai Erera <[email protected]> wrote: > Version might be a good idea. Version also has onOrAfter (compare) method, > which if we'll use for SI.getVersion, will make > StringHelper.versionComparator moot? > Today we write a String (x.y) as the segment's version. We can add methods > to Version to (de)serialize itself from/to that String. > Are you proposing we change SI.getVersion to return Version instead of > String? Are we allowed to do that (on 3x)? We can deprecate it and add > getCodeVersion (or some other name). > Then, Constants.LUCENE_MAIN_VERSION can point to the latest Version, instead > of a fixed string.
It sure would be nice to use strongly-typed Version everywhere instead of strings... the StringHelper.versionComparator would then definitely be moot and could be deleted. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
