[
https://issues.apache.org/jira/browse/LUCENE-7701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962680#comment-15962680
]
ASF subversion and git services commented on LUCENE-7701:
---------------------------------------------------------
Commit caf329717ef643b2a5a8b7ef0bfb7bd5e096c849 in lucene-solr's branch
refs/heads/master from [~romseygeek]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=caf3297 ]
LUCENE-7701: Refactor grouping collectors
> Refactor grouping collectors
> ----------------------------
>
> Key: LUCENE-7701
> URL: https://issues.apache.org/jira/browse/LUCENE-7701
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Fix For: master (7.0)
>
> Attachments: LUCENE-7701.patch, LUCENE-7701.patch
>
>
> Grouping currently works via abstract collectors, which need to be overridden
> for each way of defining a group - currently we have two, 'term' (based on
> SortedDocValues) and 'function' (based on ValueSources). These collectors
> all have a lot of repeated code, and means that if you want to implement your
> own group definitions, you need to override four or five different classes.
> This would be easier to deal with if instead the 'group selection' code was
> abstracted out into a single interface, and the various collectors were
> changed to concrete implementations.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
