[
https://issues.apache.org/jira/browse/SOLR-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967510#comment-15967510
]
Noble Paul commented on SOLR-10418:
-----------------------------------
My observations
* The patch does not close close the solrclient in
{{testMetricsMapProperties()}}
* The output for the query
http://localhost:8983/solr/admin/metrics?wt=json&json.nl=map&prefix=system.properties.user.home
has more information that I asked for
{code}
{
"metrics":{
"solr.jetty":{},
"solr.core.gettingstarted.shard1.replica2":{},
"solr.jvm":{
"system.properties":{"value":{"user.home":"/Users/noble"}}},
"solr.node":{},
"solr.core.gettingstarted.shard2.replica2":{}}}
{code}
You can simplify the testcase
{code}
nl = (NamedList)nl.get("metrics");
assertNotNull("metrics", nl);
nl = (NamedList)nl.get("solr.jvm");
assertNotNull("solr.jvm", nl);
map = (Map)nl.get("system.properties");
assertNotNull("system.properties", map);
map = (Map)map.get("value");
assertNotNull("value", map);
userHome = (String)map.get("user.home");
assertNotNull("user.home", userHome);
assertEquals(System.getProperty("user.home"), userHome);
{code}
the above can be replaced with
{code}
assertEquals(userHome, Utils.getObjectByPath(nl.asMap(5),true,
"metrics/solr.jvm/system.properties/value/user.home"));
{code}
> metrics should return JVM system properties
> -------------------------------------------
>
> Key: SOLR-10418
> URL: https://issues.apache.org/jira/browse/SOLR-10418
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Reporter: Noble Paul
> Assignee: Andrzej Bialecki
> Attachments: SOLR-10418.patch, SOLR-10418.patch, SOLR-10418.patch
>
>
> We need to stop using the custom solution used in rules and start using
> metrics for everything
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
