[
https://issues.apache.org/jira/browse/SOLR-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967638#comment-15967638
]
Shalin Shekhar Mangar edited comment on SOLR-10418 at 4/13/17 2:20 PM:
-----------------------------------------------------------------------
bq. So what are the properties that we should add by default to that list?
Should this list be retrieved from a system property too?
A list like that doesn't exist but here are the ones I came up with:
* {{javax.net.ssl.keyStorePassword}}
* {{javax.net.ssl.trustStorePassword}}
* {{basicauth}} - used in PreemptiveBasicAuthClientBuilderFactory
* {{zkDigestPassword}}
* {{zkDigestReadonlyPassword}}
I don't like the idea of retrieving this from a system property. The problem is
that if you want to ban a property, you likely want to ban it from all nodes in
the cluster. Setting up system properties is a messy way to do it. It is better
to configure the metrics handler itself in solr.xml
was (Author: shalinmangar):
bq. So what are the properties that we should add by default to that list?
Should this list be retrieved from a system property too?
A list like that doesn't exist but here are the ones I came up with:
* {{javax.net.ssl.keyStorePassword}}
* {{javax.net.ssl.trustStorePassword}}
* {{basicauth}} - used in PreemptiveBasicAuthClientBuilderFactory
* zkDigestPassword
* zkDigestReadonlyPassword
I don't like the idea of retrieving this from a system property. The problem is
that if you want to ban a property, you likely want to ban it from all nodes in
the cluster. Setting up system properties is a messy way to do it. It is better
to configure the metrics handler itself in solr.xml
> metrics should return JVM system properties
> -------------------------------------------
>
> Key: SOLR-10418
> URL: https://issues.apache.org/jira/browse/SOLR-10418
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Reporter: Noble Paul
> Assignee: Andrzej Bialecki
> Attachments: SOLR-10418.patch, SOLR-10418.patch, SOLR-10418.patch
>
>
> We need to stop using the custom solution used in rules and start using
> metrics for everything
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
