Hoss Man created SOLR-10502:
-------------------------------

             Summary: CurrencyField should support/default to docvalues for 
underlying polyfields
                 Key: SOLR-10502
                 URL: https://issues.apache.org/jira/browse/SOLR-10502
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: Hoss Man


Noticed while working on SOLR-10472, This is currently in {{CurrencyField}} ...

{code}
  private void createDynamicCurrencyField(String suffix, FieldType type) {
    String name = "*" + POLY_FIELD_SEPARATOR + suffix;
    Map<String, String> props = new HashMap<>();
    props.put("indexed", "true");
    props.put("stored", "false");
    props.put("multiValued", "false");
    props.put("omitNorms", "true");
    int p = SchemaField.calcProps(name, type, props);
    schema.registerDynamicFields(SchemaField.create(name, type, p, null));
  }
// ...
  @Override
  public void inform(IndexSchema schema) {
    this.schema = schema;
    createDynamicCurrencyField(FIELD_SUFFIX_CURRENCY,   fieldTypeCurrency);
    createDynamicCurrencyField(FIELD_SUFFIX_AMOUNT_RAW, fieldTypeAmountRaw);
  }
{code}

...this code should probably be changed to use docValues by default -- or at 
the very least use the indexed/docValues options from the original (user 
configured) {{CurrencyField}} when creating the underlying poly-fields. 
(although in this case we'll want to be careful to ensure that if it's 
{{docValues=true}} we should only end up with 2 sets of docValues -- suffix_raw 
& suffix_currency -- and not 3, including the original)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to