[
https://issues.apache.org/jira/browse/SOLR-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973597#comment-15973597
]
ASF subversion and git services commented on SOLR-10472:
--------------------------------------------------------
Commit dedb0255947ed936e001b244ff1859075398dc40 in lucene-solr's branch
refs/heads/branch_6x from Chris Hostetter
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dedb025 ]
SOLR-10472: Fixed uninversion (aka: FieldCache) bugs with the numeric
PointField classes, and CurrencyField
(cherry picked from commit 10772121eee97023aed415751e49a06d116b26ad)
Conflicts in test due to slightly diff internal DocValues APIs on master vs 6x
solr/core/src/test/org/apache/solr/schema/TestPointFields.java
> Fix uninversioning of (single valued) PointFields & clean up some related code
> ------------------------------------------------------------------------------
>
> Key: SOLR-10472
> URL: https://issues.apache.org/jira/browse/SOLR-10472
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Assignee: Hoss Man
> Attachments: SOLR-10472.patch, SOLR-10472.patch, SOLR-10472.patch
>
>
> In getting caught up with the new PointsField work in SOLR-8396 & SOLR-9987 I
> realized:
> * There's some inconsistencies/contridictions in how the new field types
> implement {{FieldType.getUninversionType}} vs some of the error handling
> added to methods like {{SchemaField.checkSortability}}.
> * as part of SOLR-9987, {{SORTED_foo}} constants were added to
> {{UninvertingReader}} and used in the {{getUninversionType}} methods for
> PointFields -- even though those constants are useless (because
> {{UninvertingReader}} doesn't support uninverting multivalued points:
> SOLR-9202)
> * the changes made to methods like {{SchemaField.checkSortability}} to
> explicitly check {{isPointsField}} should have never been needed if those
> methods were paying attention to {{getUninversionType}} -- but those types of
> checks weren't added when {{getUninversionType}} was introduced (the existing
> checks pre-date the DocValues API, back where any single-valued indexed field
> was implicitily "uninvertable")
> * If all of the above is corrected, the only thing preventing
> {{UninvertedReader}} from working properly with Solr's new PointField types
> (in the single valued case) is a trivial bug in {{IndexSchema}} (being
> presumptutious about what is uninvertable)
> I'm opening this issue to track fixing all of this, such that the end result
> will be:
> * single valued PointFields will be uninvertable (ie: sortable even if they
> don't have docvalues)
> * error handling code will be simplified
> * unused/unsupported/misleading constants in {{UninvertingReader}} will be
> removed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
