[ 
https://issues.apache.org/jira/browse/SOLR-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13038817#comment-13038817
 ] 

Mark Miller commented on SOLR-2530:
-----------------------------------

bq. nocommit in SimpleFacets with a TODO.

I've looked into this in the past - its fine. Perhaps it's safer to change it 
(equals or enum or whatever), but all current usage uses the same constant.

> Remove Noggit CharArr from FieldType
> ------------------------------------
>
>                 Key: SOLR-2530
>                 URL: https://issues.apache.org/jira/browse/SOLR-2530
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>              Labels: api-change
>             Fix For: 4.0
>
>         Attachments: SOLR-2530.patch, SOLR-2530.patch, SOLR-2530.patch, 
> SOLR-2530.patch, SOLR-2530.patch, SOLR-2530.patch
>
>
> FieldType#indexedToReadable(BytesRef, CharArr) uses a noggit dependency that 
> also spreads into ByteUtils. The uses of this method area all convert to 
> String which makes this extra reference and the dependency unnecessary. I 
> refactored it to simply return string and removed ByteUtils entirely. The 
> only leftover from BytesUtils is a constant, i moved that one to Lucenes 
> UnicodeUtils. I will upload a patch in a second

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to