[ 
https://issues.apache.org/jira/browse/SOLR-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dr Oleg Savrasov updated SOLR-10520:
------------------------------------
    Attachment: SOLR_10520.patch

I think the component should handle shard responses only in case of 
ShardRequest.PURPOSE_GET_TOP_IDS, like for example FacetComponent. Appropriate 
fix is attached. The test is modified to randomly choose either 0 or 10 value 
for "rows" parameter. Random value of "distrib.singlePass" is also verified. 
The test may be extended to check other parameters that potentially affect 
shards purpose flow.

> BlockJoinFacetComponet duplicate counts when rows>0
> ---------------------------------------------------
>
>                 Key: SOLR-10520
>                 URL: https://issues.apache.org/jira/browse/SOLR-10520
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mikhail Khludnev
>         Attachments: SOLR_10520.patch, SOLR-10520-test.patch
>
>
> when we have rows>0 every shard receive:
> bq. ids=2,3,6,7,9&isShard=true&shards.purpose=64&distrib=false
> this is ShardRequest.PURPOSE_GET_TOP_IDS
> In this case {{child_facet_fields}} are merged once again unnecessary. 
> failure is 
> {code}
> java.lang.AssertionError: don't({3=[1], s=[6], white=[0, 3, 5, 6, 7, 8, 9, 
> 10], xl=[8], don't=[0, 1, 2, 5, 6, 8, 10], 6=[0, 2, 7], xml=[3, 6, 8], 
> xxxl=[0, 7, 9], l=[8, 10], m=[5, 9, 10], xxl=[5], grey=[9]} COLOR_s:[don't 
> (14), white (16), grey (2)] SIZE_s:[m (6), xxl (2), 6 (6), s (2), xml (6), 
> xxxl (6), 3 (2), l (4), xl (2)]) expected:<7> but was:<14>
>       at __....
> org.apache.solr.search.join.BlockJoinFacetDistribTest.testBJQFacetComponent(BlockJoinFacetDistribTest.java:148)
> {code}
> see test patch attached
> I suppose it's worth to exclude not only PURPOSE_GET_TOP_IDS but any other 
> too, and make sure that _reduce_ is done only once on distributed search. 
>   



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to