[ 
https://issues.apache.org/jira/browse/SOLR-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13039100#comment-13039100
 ] 

Michael McCandless commented on SOLR-2524:
------------------------------------------

I do agree this is a real risk, Hoss.  Ie, if 3.x Solr uses the
grouping module but trunk does not, it's not great.

For example, the grouping module is already faster than trunk Solr's
grouping impl (because of CachingCollector), and also adds a new
request param (groups.cacheMaxMB).  Once LUCENE-3097 is in, we can
enable 3.x Solr to count facets post-grouping, which'll be another new
grouping request param.  The single pass grouping collector is another
good improvement (though I don't know how Solr will take advantage of
this... it'd need control over "doc blocks" while indexing, which'd be
a major change).  The two impls will continue to diverge...

That said, the plan is definitely to get Solr 4.0 cutover to the
grouping module; it's just a matter of time.  I don't think we should
ship 4.0 until we've done so.

The only missing piece now is grouping by a FunctionQuery's DocValues.
If we do LUCENE-3099 (let a subclass customize the grouping "key"), or
if we factor out the shared FQ module (LUCENE-2883), then we can
cutover Solr trunk.


> Adding grouping to Solr 3x
> --------------------------
>
>                 Key: SOLR-2524
>                 URL: https://issues.apache.org/jira/browse/SOLR-2524
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 3.2
>            Reporter: Martijn van Groningen
>            Assignee: Michael McCandless
>         Attachments: SOLR-2524.patch, SOLR-2524.patch, SOLR-2524.patch
>
>
> Grouping was recently added to Lucene 3x. See LUCENE-1421 for more 
> information.
> I think it would be nice if we expose this functionality also to the Solr 
> users that are bound to a 3.x version.
> The grouping feature added to Lucene is currently a subset of the 
> functionality that Solr 4.0-trunk offers. Mainly it doesn't support grouping 
> by function / query.
> The work involved getting the grouping contrib to work on Solr 3x is 
> acceptable. I have it more or less running here. It supports the response 
> format and request parameters (expect: group.query and group.func) described 
> in the FieldCollapse page on the Solr wiki.
> I think it would be great if this is included in the Solr 3.2 release. Many 
> people are using grouping as patch now and this would help them a lot. Any 
> thoughts?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to