[
https://issues.apache.org/jira/browse/LUCENE-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981103#comment-15981103
]
David Smiley commented on LUCENE-7585:
--------------------------------------
I'm looking over this patch again.
* CONSUME_ALL_TOKENS is only used by LimitTokenCountFilterFactory thus
shouldn't be in CommonAnalysisFactoryParams?
* Can you please try and say _a little_ something about a parameter in the
javadoc other than simply repeating the name (which isn't helpful). For
example "dictionary" refers _to a file_ -- that's helpful. Perhaps not for
min/max or any other intuitive param.
* I see you chose to use these constants in the tests. I recall
[[email protected]] once recommending that Solr tests should not refer to Solr
parameter constants because doing so may make it easier to introduce a
back-compat break. That makes sense to me and the concept applies here to.
BTW nice attention to detail in some classes.... I noticed you corrected some
javadocs and added some value set constraints.
> Interface for common parameters used across analysis factories
> --------------------------------------------------------------
>
> Key: LUCENE-7585
> URL: https://issues.apache.org/jira/browse/LUCENE-7585
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 6.3
> Reporter: Ahmet Arslan
> Assignee: David Smiley
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: LUCENE-7585.patch, LUCENE-7585.patch, LUCENE-7585.patch,
> LUCENE-7585.patch, LUCENE-7585.patch, LUCENE-7585.patch
>
>
> Certain parameters (String constants) are same/common for multiple analysis
> factories. Some examples are {{ignoreCase}}, {{dictionary}}, and
> {{preserveOriginal}}. These string constants are handled inconsistently in
> different factories. This is an effort to define most common constants in
> ({{CommonAnalysisFactoryParams}}) interface and reuse them.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
